kaisun2000 commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r465398354
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1360,6 +1369,8 @@ private boolean updateControllerState(NotificationContext
changeContext, PauseSi
String uid = UUID.randomUUID().toString().substring(0, 8);
ClusterEvent event = new ClusterEvent(_clusterName,
ClusterEventType.Resume,
String.format("%s_%s", uid, Pipeline.Type.DEFAULT.name()));
+ event.addAttribute(AttributeName.EVENT_SESSION.name(),
+ changeContext.getManager().getSessionIdIfLead());
Review comment:
This part is actually debatable? updateControllerState is used to pause
or restart paused pipeline. Do it care about session? Can we lose this signal
due to session check? How do we reason this one?
I am not very familiar with this logic. @jiajunwang , @lei-xia, @dasahcc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
