narendly opened a new pull request #1178: URL: https://github.com/apache/helix/pull/1178
### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #1162 Fixes #1175 Fixes #1176 Fixes #1177 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: This PR contains a host of ZooScalability feature additions for usability. For details, please see the individual commit titles and messages. Implement RoutingDataManager to replace HttpRoutingDataReader Change interface for RoutingDataReader Add HttpZkFallbackRoutingDataReader Implement ZkRoutingDataReader Modify realm-aware ZkClient and Helix API for configurable routing source Make RoutingDataManager a pure Singleton with double-checked locking Implement routing data update upon cache miss for FederatedZkClient ### Tests - [x] The following tests are written for this issue: Various tests are added to ensure the features are stable and correct. Please see the individual commits. - [x] The following is the result of the "mvn test" command on the appropriate module: zookeeper-api: ``` [INFO] Tests run: 41, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.96 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 41, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS ``` helix-core: ``` [ERROR] Failures: [ERROR] TestEnableCompression.testEnableCompressionResource:116 ยป ThreadTimeout Method... [ERROR] TestRebalanceRunningTask.testFixedTargetTaskAndEnabledRebalanceAndNodeAdded:330 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 1155, Failures: 2, Errors: 0, Skipped: 1 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE ``` Two failures run individually: ``` [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.574 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS ``` helix-rest: ``` [INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.261 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS ``` ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [x] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
