narendly commented on a change in pull request #1178:
URL: https://github.com/apache/helix/pull/1178#discussion_r470296214
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/RealmAwareZkClient.java
##########
@@ -486,6 +500,13 @@ private void validate() {
throw new IllegalArgumentException(
"RealmAwareZkConnectionConfig.Builder: ZK sharding key must be
set on single-realm mode!");
}
+ if ((_routingDataSourceEndpoint == null && _routingDataSourceType !=
null) || (
+ _routingDataSourceEndpoint != null && _routingDataSourceType ==
null)) {
+ // For routing data source type and endpoint, if one is set and not
the other, it is invalid
Review comment:
DedicatedZkClientFactory gives 2 methods - one for RealmAwareZkClient,
and another for HelixZkClient. The former should be used when you plan on using
ZooKeeper in a multi-zk way, the latter is for when you only have one ZK (and
therefore need to provide a valid ZkAddress). Or the user can use Raw zkClient
as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
