kaisun2000 opened a new pull request #1185:
URL: https://github.com/apache/helix/pull/1185
### Issues
- [x] My PR addresses the following Helix issues #1184
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
ZkHelixClusterVerifier and its subclass built with ZK addres would
create an internal ZkClient. Without properly closing the ZkClient
or using global ZkClient in the test base. There would be four
threads and one ZooKeeper client object leaked. The leaked threads
would be in thousands and thus be one of the main contributor
preventing the unit test from finishing. This pull request address
this issue.
### Tests
- [ ] The following tests are written for this issue:
None
- [ ] The following is the result of the "mvn test" command on the
appropriate module:
(Copy & paste the result of "mvn test")
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in
their subject lines. In addition, my commits follow the guidelines from "[How
to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the
following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [ ] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
