pkuwm commented on a change in pull request #1185:
URL: https://github.com/apache/helix/pull/1185#discussion_r462079073
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/callback/ZkAsyncCallbacks.java
##########
@@ -120,6 +122,41 @@ public void handle() {
}
}
+ public static class SyncCallbackHandler extends DefaultCallback implements
AsyncCallback.VoidCallback {
Review comment:
@kaisun2000 Could you rebase this PR with master?
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/manager/ClusterManager.java
##########
@@ -74,7 +81,8 @@ public void syncStart() {
_watcher = new Thread(this);
_watcher.setName(String
- .format("ClusterManager_Watcher_%s_%s_%s", _clusterName,
_instanceName, _type.name()));
+ .format("ClusterManager_Watcher_%s_%s_%s_%d", _clusterName,
_instanceName, _type.name(), _uid));
+ LOG.info("ClusterManager_watcher_{}_{}_{}_{} started, stacktrace {}",
_clusterName, _instanceName, _type.name(), _uid,
Thread.currentThread().getStackTrace());
Review comment:
It seems this log is for your debugging. Do we want to remove it then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
