jiajunwang opened a new pull request #1190: URL: https://github.com/apache/helix/pull/1190
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: #1189 ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: Add a new Helix rest API in the ZookeeperAccessor for deleting an ephemeral ZNode. Note that before we have ACL/audit support in the Helix rest, allowing raw ZK write operation is dangerous. This API is introduced prematurely for resolving the issue of "zombie" participant (the instance has an active zk connection, but refuse to do any work). Currently, the existence of such a node may block the normal state transitions and then impact the cluster's availability. This PR restricts that only an ephemeral node can be deleted to minimize the risk. ### Tests - [X] The following tests are written for this issue: TestZooKeeperAccessor.testDelete() - [ ] The following is the result of the "mvn test" command on the appropriate module: helix-rest [INFO] Tests run: 164, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.852 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 164, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 52.162 s [INFO] Finished at: 2020-07-29T18:06:03-07:00 [INFO] ------------------------------------------------------------------------ ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
