jiajunwang commented on a change in pull request #1190:
URL: https://github.com/apache/helix/pull/1190#discussion_r463227545
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/ZooKeeperAccessor.java
##########
@@ -52,12 +51,15 @@
private static final Logger LOG =
LoggerFactory.getLogger(ZooKeeperAccessor.class.getName());
private BaseDataAccessor<byte[]> _zkBaseDataAccessor;
+ private static final String PATH_STR = "path";
+
public enum ZooKeeperCommand {
exists,
getBinaryData,
getStringData,
getChildren,
- getStat
+ getStat,
+ delete
Review comment:
I don't think we want "deleteEphemeral" eventually. As mentioned in the
description, this is a premature feature that we add now for unblocking our
users.
Alternatively, I tried to allow deleting live instance only. But that will
pollute the ZookeeperAccessor API with Helix logics. So I discarded that idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
