narendly commented on a change in pull request #1190:
URL: https://github.com/apache/helix/pull/1190#discussion_r463230652
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/ZooKeeperAccessor.java
##########
@@ -52,12 +51,15 @@
private static final Logger LOG =
LoggerFactory.getLogger(ZooKeeperAccessor.class.getName());
private BaseDataAccessor<byte[]> _zkBaseDataAccessor;
+ private static final String PATH_STR = "path";
+
public enum ZooKeeperCommand {
exists,
getBinaryData,
getStringData,
getChildren,
- getStat
+ getStat,
+ delete
Review comment:
I still don't agree - it seems that you are suggesting using `delete`,
expecting its behavior to change in the future. That will bring about
backward-compatibility issues and make the meaning of "delete" murky. Moreover,
there's no harm in having `deleteEphemeral`.
It's fine if you need to provide another endpoint/API, but a good API design
involves something that is 1) easy to do and 2) doing exactly what it's
advertising to do. Do you see why I think it might be less desirable to add
hidden assumptions to `delete`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
