pkuwm commented on a change in pull request #1194:
URL: https://github.com/apache/helix/pull/1194#discussion_r463345847
##########
File path:
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestRawZkClient.java
##########
@@ -868,59 +864,38 @@ public void testAsyncWriteOperations() {
* Tests getChildren() when there are an excessive number of children and
connection loss happens,
* the operation should terminate and exit retry loop.
*/
- @Test
+ @Test(timeOut = 30L)
Review comment:
`30 * 1000L ms`.
A good practice would be: if the test relies on an external system(zk here),
it'd be good to have a timeout. Otherwise, if the connection hangs, the test
also hangs. Eg., if the operation `multi()` hangs since it is sync, it hangs
there forever?
Timeout makes the test process continue for other tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
