pkuwm commented on a change in pull request #1194:
URL: https://github.com/apache/helix/pull/1194#discussion_r463351044
##########
File path:
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestRawZkClient.java
##########
@@ -868,59 +864,38 @@ public void testAsyncWriteOperations() {
* Tests getChildren() when there are an excessive number of children and
connection loss happens,
* the operation should terminate and exit retry loop.
*/
- @Test
+ @Test(timeOut = 30L)
Review comment:
This _zkClient is created within this class. While this test is running,
there is no other thread referencing this _zkClient to close it.
I considered using another zkClient. But it just adds one more connection to
so for this case there will be two connections at the same time. I believe
reuse this one is good enough.
I ran it in my laptop as well, 30s is good enough. If it's more than 30s,
something is wrong and it should timeout to fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
