jiajunwang opened a new pull request #1215: URL: https://github.com/apache/helix/pull/1215
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: Resolves #627 ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: The null check or empty check disallow class users to clean up the corresponding fields. This change remove these checkes in follow methods, - ClusterConfig.setDefaultCapacityMap - ClusterConfig.setGlobalRebalancePreference - ClusterConfig.setAbnormalStateResolverMap - InstanceConfig.setInstanceCapacityMap ### Tests - [X] The following tests are written for this issue: Modify the existing tests to cover the new change. - [X] The following is the result of the "mvn test" command on the appropriate module: helix-core [ERROR] Failures: [ERROR] TestAutoRebalance.testAutoRebalance:177 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 1151, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:17 h [INFO] Finished at: 2020-08-04T00:12:37-07:00 [INFO] ------------------------------------------------------------------------ Rerun [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 19.694 s [INFO] Finished at: 2020-08-04T11:03:57-07:00 [INFO] ------------------------------------------------------------------------ helix-rest [INFO] Tests run: 164, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 53.047 s [INFO] Finished at: 2020-08-04T11:05:11-07:00 [INFO] ------------------------------------------------------------------------ ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
