kaisun2000 commented on a change in pull request #1215:
URL: https://github.com/apache/helix/pull/1215#discussion_r466063495
##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -859,13 +866,18 @@ public boolean isGlobalRebalanceAsyncModeEnabled() {
/**
* Set the abnormal state resolver class map.
+ * @param resolverMap - the resolver map
+ * If null, the resolver map item will be removed from
the config.
*/
public void setAbnormalStateResolverMap(Map<String, String> resolverMap) {
- if (resolverMap.values().stream()
- .anyMatch(className -> className == null || className.isEmpty())) {
+ if (resolverMap != null && resolverMap.values().stream()
Review comment:
I am a little bit confused.
`anyMatch(className -> className == null))` means if there is a className
(key) in resolverMap, we throw exception.
Then how about value in resolverMap, can it be null? What does it mean then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
