kaisun2000 opened a new pull request #1295: URL: https://github.com/apache/helix/pull/1295
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Fix #1294 ZkClient connect to ZooKeeper client first before monitor bean initialization. If the monitor is not fully constructed, the test would pass. Otherwise, as in github, it would not. Fix this issue by properly construct the object. ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: (Write a concise description including what, why, how) ### Tests - [ ] The following tests are written for this issue: (List the names of added unit/integration tests) - [x] The following is the result of the "mvn test" command on the appropriate module: In Old connection New session After session expiry sessionId= 72277739317428225 Shut down zookeeper at port 2127 in thread main Starting ZK server at localhost:2358 [INFO] Tests run: 44, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 701.476 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 44, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 11:47 min [INFO] Finished at: 2020-08-19T18:11:02-07:00 [INFO] ------------------------------------------------------------------------ ksun-mn1:zookeeper-api ksun$ git status ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
