kaisun2000 commented on a change in pull request #1295:
URL: https://github.com/apache/helix/pull/1295#discussion_r474349621
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -2156,6 +2160,21 @@ public void connect(final long
maxMsToWaitUntilConnected, Watcher watcher)
LOG.debug("ZkClient created with _uid {}, _eventThread {}", _uid,
_eventThread.getId());
+ // initiate monitor
+ try {
+ if (_monitorKey != null && !_monitorKey.isEmpty() && _monitorType !=
null && !_monitorType
+ .isEmpty()) {
+ _monitor =
+ new ZkClientMonitor(_monitorType, _monitorKey,
_monitorInstanceName, _monitorRootPathOnly,
Review comment:
My thinking is that ZkClientMonitor does not hold any session object,
nor thread. Let GC deal with it would be fine. Or do you see otherwise?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
