pkuwm commented on a change in pull request #1237:
URL: https://github.com/apache/helix/pull/1237#discussion_r475063343
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -213,7 +219,12 @@ public StoppableCheck getInstanceStoppableCheck(String
clusterId, String instanc
instancesForNextCheck.add(instance);
}
} catch (InterruptedException | ExecutionException e) {
- LOG.error("Failed to get StoppableChecks in parallel. Instance: {}",
instance, e);
+ LOG.warn("Failed to get StoppableChecks in parallel. Instance: {}.
Caused by {}", instance,
Review comment:
I feel error is inappropriate for this kind of msg. It is not a server
error.
ERROR should contain technical issues that need to be resolved for proper
functioning of the system (ex: couldn’t connect to database)
WARN is best used for temporary problems or unexpected behavior that does
not significantly hamper the functioning of the application (ex: failed user
login)
INFO should contain messages that describe what is happening in the
application (ex: user registered, order placed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
