pkuwm commented on a change in pull request #1237:
URL: https://github.com/apache/helix/pull/1237#discussion_r475067511
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceService.java
##########
@@ -72,9 +72,10 @@
/**
* Pre-defined list of checks to test if an instance is in healthy
running state
*/
- public static List<HealthCheck> STARTED_AND_HEALTH_CHECK_LIST =
- ImmutableList.of(HealthCheck.INSTANCE_NOT_ALIVE,
HealthCheck.INSTANCE_NOT_ENABLED,
- HealthCheck.INSTANCE_NOT_STABLE,
HealthCheck.EMPTY_RESOURCE_ASSIGNMENT);
+ public static List<HealthCheck> STARTED_AND_HEALTH_CHECK_LIST =
ImmutableList
+ .of(HealthCheck.INVALID_CONFIG, HealthCheck.INSTANCE_NOT_ALIVE,
Review comment:
@dasahcc `INVALID_CONFIG` should also be added to
STARTED_AND_HEALTH_CHECK_LIST, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
