mgao0 commented on a change in pull request #1302:
URL: https://github.com/apache/helix/pull/1302#discussion_r475934762
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java
##########
@@ -410,7 +410,11 @@ public void testCustomizedViewAggregation() throws
Exception {
// Aggregating: Type A
// Routing table: Type A, Type B, Type C
setAggregationEnabledTypes(Arrays.asList(CustomizedStateType.TYPE_A));
- validateAggregationSnapshot();
+ // This is commented out as a work around to pass the test
+ // The validation of config change will be done combined with the next
several customized state changes
+ // The next validation should only show TYPE_A states aggregated in
customized view
+ // Until we fix the issue in routing table provider
https://github.com/apache/helix/issues/1296
+// validateAggregationSnapshot();
Review comment:
@kaisun2000
Helix controller reads the config and produces customized views. When the
controller found from the config that type C has been dropped, it deletes the
type C customized views from zk too (everything under
/cluster_name/CUSTOMIZEDVIEW/TYPE_C).
We have one callback handler each for type A, B and C customized view
(/cluster_name/CUSTOMIZEDVIEW/TYPE_C) as parent path. We also have one callback
handler for each of their children nodes, which is like the example I gave
earlier /cluster_name/CUSTOMIZEDVIEW/TYPE_C/resource_name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
