mgao0 commented on a change in pull request #1302:
URL: https://github.com/apache/helix/pull/1302#discussion_r475970901
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java
##########
@@ -410,7 +410,11 @@ public void testCustomizedViewAggregation() throws
Exception {
// Aggregating: Type A
// Routing table: Type A, Type B, Type C
setAggregationEnabledTypes(Arrays.asList(CustomizedStateType.TYPE_A));
- validateAggregationSnapshot();
+ // This is commented out as a work around to pass the test
+ // The validation of config change will be done combined with the next
several customized state changes
+ // The next validation should only show TYPE_A states aggregated in
customized view
+ // Until we fix the issue in routing table provider
https://github.com/apache/helix/issues/1296
+// validateAggregationSnapshot();
Review comment:
No we don’t have the same problem for current states. For example if you
drop a resource in current states it enters this condition in
handleChildChange, because it's not a parent path.
`else {
if (!isReady()) {
// avoid leaking CallbackHandler
logger.info("Callbackhandler {} with path {} is in reset state.
Stop subscription to ZK client to avoid leaking",
this, parentPath);
return;
}
NotificationContext changeContext = new
NotificationContext(_manager);
changeContext.setType(NotificationContext.Type.CALLBACK);
changeContext.setPathChanged(parentPath);
changeContext.setChangeType(_changeType);
subscribeForChanges(changeContext.getType(), _path, _watchChild);
enqueueTask(changeContext);
}
}
`
So it sends a CALLBACK instead of FINALIZE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
