NealSun96 opened a new pull request #1327:
URL: https://github.com/apache/helix/pull/1327
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
#1320
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
The setters were not actually setting the InstanceConfig/ClusterConfig. The
test cases were also constructed incorrectly; the original ordering caused the
"setting tests" to use the values set in the "getting tests" and therefore they
are not correctly testing the setters. They are now ordered such that the
setting tests are performed first.
### Tests
- [x] The following is the result of the "mvn test" command on the
appropriate module:
```
[ERROR] Tests run: 1164, Failures: 5, Errors: 0, Skipped: 1, Time elapsed:
4,645.579 s <<< FAILURE! - in TestSuite
[ERROR]
testChangeIdealState(org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedRebalance)
Time elapsed: 6.08 s <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
at
org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedRebalance.validate(TestWagedRebalance.java:614)
at
org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedRebalance.testChangeIdealState(TestWagedRebalance.java:271)
[ERROR]
testFixedTargetTaskAndEnabledRebalanceAndNodeAdded(org.apache.helix.integration.task.TestRebalanceRunningTask)
Time elapsed: 10.424 s <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
at
org.apache.helix.integration.task.TestRebalanceRunningTask.testFixedTargetTaskAndEnabledRebalanceAndNodeAdded(TestRebalanceRunningTask.java:330)
[ERROR]
testWorkflowJobFail(org.apache.helix.integration.task.TestWorkflowTermination)
Time elapsed: 10.139 s <<< FAILURE!
org.apache.helix.HelixException: Workflow "testWorkflowJobFail" context is
empty or not in states: "[FAILED]", current state: "IN_PROGRESS"
at
org.apache.helix.integration.task.TestWorkflowTermination.testWorkflowJobFail(TestWorkflowTermination.java:223)
[ERROR]
testEnableCompressionResource(org.apache.helix.integration.TestEnableCompression)
Time elapsed: 285.579 s <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
at
org.apache.helix.integration.TestEnableCompression.testEnableCompressionResource(TestEnableCompression.java:117)
[ERROR]
testStateTransitionTimeOut(org.apache.helix.integration.paticipant.TestStateTransitionTimeout)
Time elapsed: 32.015 s <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
at
org.apache.helix.integration.paticipant.TestStateTransitionTimeout.testStateTransitionTimeOut(TestStateTransitionTimeout.java:166)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestEnableCompression.testEnableCompressionResource:117
expected:<true> but was:<false>
[ERROR] TestStateTransitionTimeout.testStateTransitionTimeOut:166
expected:<true> but was:<false>
[ERROR] TestWagedRebalance.testChangeIdealState:271->validate:614
expected:<true> but was:<false>
[ERROR]
TestRebalanceRunningTask.testFixedTargetTaskAndEnabledRebalanceAndNodeAdded:330
expected:<true> but was:<false>
[ERROR] TestWorkflowTermination.testWorkflowJobFail:223 ยป Helix Workflow
"testWorkflow...
[INFO]
[ERROR] Tests run: 1164, Failures: 5, Errors: 0, Skipped: 1
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:17 h
[INFO] Finished at: 2020-08-27T16:04:46-07:00
[INFO]
------------------------------------------------------------------------
```
Rerun
```
[INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
111.927 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:57 min
[INFO] Finished at: 2020-08-27T16:36:17-07:00
[INFO]
------------------------------------------------------------------------
```
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
