NealSun96 opened a new pull request #1326:
URL: https://github.com/apache/helix/pull/1326
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
#1323, #1324, #1325
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This PR removes IdealState usage from the task framework pipeline. Instead,
now workflow resources are created directly using WorkflowConfig and JobConfig.
As a result, the legacy pipeline logic in TaskSchedulingStage is removed: it
was there for the case of "IdealState exists but not WorkflowConfig", which is
no longer possible now.
After the removal of legacy pipeline logic, numerous unintended usage of the
legacy pipeline were uncovered in the form of broken tests; these tests are
addressed and fixed.
At the same time, 2 bugs in the pipeline were also uncovered and fixed: the
first one is about tasks being incorrectly rejected; the second one is about
negative scheduling delay not properly rejected.
### Tests
- [x] The following is the result of the "mvn test" command on the
appropriate module:
```
[ERROR] Tests run: 1173, Failures: 2, Errors: 0, Skipped: 1, Time elapsed:
4,319.525 s <<< FAILURE! - in TestSuite
[ERROR]
testEnableCompressionResource(org.apache.helix.integration.TestEnableCompression)
Time elapsed: 162.594 s <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
at
org.apache.helix.integration.TestEnableCompression.testEnableCompressionResource(TestEnableCompression.java:117)
[ERROR]
testPeriodicRefresh(org.apache.helix.integration.spectator.TestRoutingTableProviderPeriodicRefresh)
Time elapsed: 2.012 s <<< FAILURE!
java.lang.AssertionError: expected:<4> but was:<3>
at
org.apache.helix.integration.spectator.TestRoutingTableProviderPeriodicRefresh.testPeriodicRefresh(TestRoutingTableProviderPeriodicRefresh.java:211)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestEnableCompression.testEnableCompressionResource:117
expected:<true> but was:<false>
[ERROR] TestRoutingTableProviderPeriodicRefresh.testPeriodicRefresh:211
expected:<4> but was:<3>
[INFO]
[ERROR] Tests run: 1173, Failures: 2, Errors: 0, Skipped: 1
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:12 h
[INFO] Finished at: 2020-08-27T13:06:45-07:00
[INFO]
------------------------------------------------------------------------
```
Rerun
```
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
30.334 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 35.472 s
[INFO] Finished at: 2020-08-27T14:42:52-07:00
[INFO]
------------------------------------------------------------------------
```
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
