pkuwm opened a new issue #1331: URL: https://github.com/apache/helix/issues/1331
### Describe the bug PreFetch annotation in class `CallbackHandler` is using `org.apache.helix.api.listeners.PreFetch`: https://github.com/apache/helix/blob/a5cddd4b8fa51b1ea53b2f7082daf79361cd81de/helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java#L106-L107 Then when it is disabled, the value is not honor in ZkClient. So ZkClient still prefetches the data for callback handler. Because in ZkClient, the annotation `org.apache.helix.zookeeper.zkclient.annotation.PreFetch` is used. ### To Reproduce Steps to reproduce the behavior. ### Expected behavior PreFetch disabled in CallbackHandler should be honored in ZkClient. No prefetch for CallbackHandler in ZkClient. ### Additional context There are two layers of prefetch: one in helix-core for callbackhandler/helix listeners(eg. InstanceConfigChangeListener), the other one in zookeeper-api for ZkClient. We want to separate these purposes by using different annotations. So the existing annotation in zookeeper-api `org.apache.helix.zookeeper.zkclient.annotation.PreFetch` is proposed to change to `org.apache.helix.zookeeper.zkclient.annotation.PreFetchChangedData` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
