dasahcc commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r485111397
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java
##########
@@ -98,6 +101,43 @@ public void process(ClusterEvent event) throws Exception {
}
}
+ // Add TaskFramework resources from workflow and job configs as Task
Framework will no longer
+ // use IdealState
+ if (isTaskCache) {
Review comment:
No. We should not change it here but in TaskSchedulingStage. We do not
need this specific process to select workflows. All we need is to get
WorkflowConfig list in Cache at TaskSchedulingStage and loop it. These
operations are unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
