NealSun96 commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r484025032
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/RebalanceScheduler.java
##########
@@ -80,6 +80,7 @@ public void scheduleRebalance(HelixManager manager, String
resource, long startT
long delay = startTime - System.currentTimeMillis();
if (delay < 0) {
LOG.debug(String.format("Delay time is %s, will not be scheduled",
delay));
+ return;
Review comment:
The initial motivation was that 1 test case is failing. After digging
around, it turns out that 1 negative delay was passed into the function, which
removes a scheduled rebalance at a later time. A part of the fix was that the
negative delay shouldn't be passed (it was unintentional), and the other part
of the fix was #1325.
I'm unable to produce any errors now that negative delays are not passed, so
I can no longer provide such a scenario.
#1325 should either be resolved by rejecting negative delay or fixing the
description and expectation of this function. For now I'll remove it from this
PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
