jiajunwang opened a new pull request #1360: URL: https://github.com/apache/helix/pull/1360
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: Resolves #1349 ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: This PR depends on #1359 , please reviewing that PR first. If no rebalancer class name is specified, use the DelayedAutoRebalancer instead of AutoRebalancer. Note that DelayedAutoRebalancer is compatible with the AutoRebalanceStrategy. So the assignment would remain the same even after migration. However, since DelayedAutoRebalancer keeps a cached rebalance result in the Controller cache, it causes a behavior change. - We need to modify multiple test classes to use the CrushEd rebalance strategy for the correct test logic. - This behavior change only impacts BestPossibleExternalViewVerifier if the resource was on the older AutoRebalancer (by DEFAULT setting) and AutoRebalanceStrategy. - If any Helix client is using BestPossibleExternalViewVerifier with the described configuration, then changing the rebalancer class config in the IdealState explicitly to AutoRebalancer is required before the Helix version bump-up. Or the BestPossibleExternalViewVerifier may fail. ### Tests - [X] The following tests are written for this issue: Multiple related tests have been updated to cover the new change. - [X] The following is the result of the "mvn test" command on the appropriate module: [INFO] Tests run: 1200, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4,453.792 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1200, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:14 h [INFO] Finished at: 2020-09-10T19:52:49-07:00 [INFO] ------------------------------------------------------------------------ ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
