jiajunwang commented on a change in pull request #1360:
URL: https://github.com/apache/helix/pull/1360#discussion_r490715085
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestAlertingRebalancerFailure.java
##########
@@ -161,7 +170,8 @@ public void testParticipantUnavailable() throws Exception {
@Test(dependsOnMethods = "testParticipantUnavailable")
public void testTagSetIncorrect() throws Exception {
_gSetupTool.addResourceToCluster(CLUSTER_NAME, testDb, 5,
- BuiltInStateModelDefinitions.MasterSlave.name(),
RebalanceMode.FULL_AUTO.name());
Review comment:
The argument here is that we do want to deprecate AutoRebalancer and
AutoRebalanceStrategy. Since they are buggy and unstable. So even the behavior
change will hurt some of their use cases, we will take it.
If this assumption does not hold, then we can never change the default
rebalancer to DelayedAutoRebalancer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
