xyuanlu commented on a change in pull request #1362:
URL: https://github.com/apache/helix/pull/1362#discussion_r488217503
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
##########
@@ -980,9 +980,10 @@ public TaskState pollForJobState(String workflowName,
String jobName, long timeo
&& System.currentTimeMillis() < st + timeout);
if (ctx == null || !allowedStates.contains(ctx.getJobState(jobName))) {
- throw new HelixException(
- String.format("Workflow \"%s\" context is null or job \"%s\" is not
in states: %s",
- workflowName, jobName, allowedStates));
+ String cur = ctx == null ? "null" : ctx.getJobState(jobName).toString();
+ throw new HelixException(String.format(
+ "Workflow \"%s\" context is null or job \"%s\" is not in states: %s,
cur state is: %s",
+ workflowName, jobName, allowedStates, cur));
Review comment:
Yes it is a log improvement. I personally find the new log more helpful
when debugging. Since we are comparing two states, printing out the expected
state and actually state could be more useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
