xyuanlu commented on a change in pull request #1362:
URL: https://github.com/apache/helix/pull/1362#discussion_r490412279
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java
##########
@@ -463,6 +442,36 @@ public void onError(Exception e, ErrorCode code, ErrorType
type) {
}
+ // Verify the fromState and current state of the stateModel.
+ private void validateStaleMessage (boolean isPreCheck) throws Exception {
+ String fromState = _message.getFromState();
+ String toState = _message.getToState();
+ String partitionName = _message.getPartitionName();
+
+ // state in _currentStateDelta uses current state from state model. It has
the
+ // most up-to-date. current state. In case currentState in stateModel is
null,
+ // partition is in initial state and we using it as current state.
+ // Defined in HelixStateMachineEngine.
+ String state = _currentStateDelta.getState(partitionName);
+
+ if (toState.equalsIgnoreCase(state)) {
+ // To state equals current state, we can just ignore the message
+ throw new HelixDuplicatedStateTransitionException(String
+ .format("Partition %s current state is same as toState (%s->%s) from
message.",
+ partitionName, fromState, toState));
+ } else if (!isPreCheck && fromState != null && !fromState.equals("*") &&
!fromState
Review comment:
TFTR.
Originally in HelixStateTransitionHandler, handling for these two cases are
different.
For the first case when toState == currentState, we just treat the task as
succeeded and finish task. There is no difference between doing the no-op when
executing and bypass the task at scheduling phase.
In the second case when currentState != fromState, executor will set the
task as failed and report state transition error. Ir will also update ZK.
Having same logic causes a test fail. Controller keeps sending many
'INIT->RUNNING' message when currentState is TASK_ERROR if we don't report task
error. Currently task error is reported in HelixStateTransitionHandler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
