kaisun2000 commented on a change in pull request #1295:
URL: https://github.com/apache/helix/pull/1295#discussion_r489832924
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -222,22 +226,16 @@ protected ZkClient(IZkConnection zkConnection, int
connectionTimeout, long opera
_asyncCallRetryThread.start();
LOG.debug("ZkClient created with _uid {}, _asyncCallRetryThread id {}",
_uid, _asyncCallRetryThread.getId());
- connect(connectionTimeout, this);
-
- // initiate monitor
- try {
- if (monitorKey != null && !monitorKey.isEmpty() && monitorType != null
&& !monitorType
- .isEmpty()) {
- _monitor =
- new ZkClientMonitor(monitorType, monitorKey, monitorInstanceName,
monitorRootPathOnly,
- _eventThread);
- _monitor.register();
- } else {
- LOG.info("ZkClient monitor key or type is not provided. Skip
monitoring.");
- }
- } catch (JMException e) {
- LOG.error("Error in creating ZkClientMonitor", e);
+ if (monitorKey != null && !monitorKey.isEmpty() && monitorType != null &&
!monitorType
+ .isEmpty()) {
+ _monitor =
+ new ZkClientMonitor(monitorType, monitorKey, monitorInstanceName,
monitorRootPathOnly,
+ _eventThread);
Review comment:
I test it. It seems not true. We need to register the bean in connect()
under the lock. Otherwise, depends on timing, you may lose one read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
