kaisun2000 commented on a change in pull request #1295:
URL: https://github.com/apache/helix/pull/1295#discussion_r489834018
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -2152,6 +2150,19 @@ public void connect(final long
maxMsToWaitUntilConnected, Watcher watcher)
IZkConnection zkConnection = getConnection();
_eventThread = new ZkEventThread(zkConnection.getServers());
+
+ if (_monitor != null) {
+ _monitor.setAndInitZkEventThreadMonitor(_eventThread);
+ }
+
+ try {
Review comment:
Note, It seems crucial to register here. Or depending on timing, we may
lose read of the first sync().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
