pkuwm commented on a change in pull request #1355:
URL: https://github.com/apache/helix/pull/1355#discussion_r493221149
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -2228,7 +2233,7 @@ public void close() throws ZkInterruptedException {
_eventThread.interrupt();
_eventThread.join(2000);
if (isManagingZkConnection()) {
- LOG.info("Closing zkclient: " + ((ZkConnection)
connection).getZookeeper());
+ LOG.info("zkclient{}, Closing zkclient zk: {} ", this._uid,
((ZkConnection) connection).getZookeeper());
Review comment:
It'd be great to make these similar messages easier to read, like
`Closing zkclient. uid={}, zk={}`?
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -105,7 +106,9 @@
@PreFetchChangedData(enabled = false)
public class CallbackHandler implements IZkChildListener, IZkDataListener {
private static Logger logger =
LoggerFactory.getLogger(CallbackHandler.class);
+ private static AtomicLong CB_UID = new AtomicLong();
Review comment:
`static final`?
And also give it a more comprehensive name, like `CALLBACK_HANDLER_UID` or
`NEXT_ID`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
