jiajunwang commented on a change in pull request #1355:
URL: https://github.com/apache/helix/pull/1355#discussion_r493901815
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -354,10 +359,10 @@ public void enqueueTask(NotificationContext
changeContext) throws Exception {
// async mode only applicable to CALLBACK from ZK, During INIT and
FINALIZE invoke the
// callback's immediately.
if (_batchModeEnabled && changeContext.getType() ==
NotificationContext.Type.CALLBACK) {
- logger.debug("Enqueuing callback");
+ logger.debug("Callbackhandler {}, Enqueuing callback", this._uid );
if (!isReady()) {
- logger.info("CallbackHandler is not ready, ignore change callback from
path: {}, for "
- + "listener: {}", _path, _listener);
+ logger.info("CallbackHandler {} is not ready, ignore change callback
from path: {}, for "
+ + "listener: {}", this._uid, _path, _listener);
Review comment:
nit, "this." in "this._uid" is not necessary, right?
Same as the following places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
