zhangmeng916 commented on a change in pull request #1432:
URL: https://github.com/apache/helix/pull/1432#discussion_r499938545
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -78,8 +78,8 @@
*/
@Deprecated
public BestPossibleExternalViewVerifier(String zkAddr, String clusterName,
Set<String> resources,
- Map<String, Map<String, String>> errStates, Set<String>
expectLiveInstances) {
- super(zkAddr, clusterName);
+ Map<String, Map<String, String>> errStates, Set<String>
expectLiveInstances, int waitTillVerify) {
Review comment:
Could you please add some doc about the rationale of adding waiting time?
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -78,8 +78,8 @@
*/
@Deprecated
public BestPossibleExternalViewVerifier(String zkAddr, String clusterName,
Set<String> resources,
- Map<String, Map<String, String>> errStates, Set<String>
expectLiveInstances) {
- super(zkAddr, clusterName);
+ Map<String, Map<String, String>> errStates, Set<String>
expectLiveInstances, int waitTillVerify) {
Review comment:
Note that these constructors are deprecated and suggest to use builder.
So you may also want to add this new parameter to the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
