kaisun2000 commented on a change in pull request #1432:
URL: https://github.com/apache/helix/pull/1432#discussion_r499951005
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -78,8 +78,8 @@
*/
@Deprecated
public BestPossibleExternalViewVerifier(String zkAddr, String clusterName,
Set<String> resources,
- Map<String, Map<String, String>> errStates, Set<String>
expectLiveInstances) {
- super(zkAddr, clusterName);
+ Map<String, Map<String, String>> errStates, Set<String>
expectLiveInstances, int waitTillVerify) {
Review comment:
This is good point.
In fact, we already added them in the builder. See this pull,
https://github.com/apache/helix/pull/1328/files
The thing is that in pull 1328, we missed some places which is addressed in
this pull.
The big pull #1227 validated that all missing ones are all addressed here.
No more missing ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
