kaisun2000 commented on a change in pull request #1447:
URL: https://github.com/apache/helix/pull/1447#discussion_r500729450
##########
File path: helix-core/src/test/java/org/apache/helix/TestListenerCallback.java
##########
@@ -131,22 +131,28 @@ public void testConfigChangeListeners() throws Exception {
TestConfigListener listener = new TestConfigListener();
listener.reset();
_manager.addInstanceConfigChangeListener(listener);
- Assert.assertTrue(listener._instanceConfigChanged,
- "Should get initial instanceConfig callback invoked");
+ boolean result = TestHelper.verify(()-> {
+ return listener._instanceConfigChanged == true;
Review comment:
removed all.
##########
File path: helix-core/src/test/java/org/apache/helix/TestZKCallback.java
##########
@@ -165,8 +166,10 @@ public void testInvocation() throws Exception {
ExternalView extView = new ExternalView("db-12345");
accessor.setProperty(keyBuilder.externalView("db-12345"), extView);
- Thread.sleep(100);
- AssertJUnit.assertTrue(testListener.externalViewChangeReceived);
+ boolean result = TestHelper.verify(() -> {
+ return testListener.externalViewChangeReceived == true;
Review comment:
removed all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
