jiajunwang commented on a change in pull request #1447:
URL: https://github.com/apache/helix/pull/1447#discussion_r501246379
##########
File path: helix-core/src/test/java/org/apache/helix/TestListenerCallback.java
##########
@@ -206,21 +206,24 @@ public void testScopedConfigChangeListener() throws
Exception {
listener.reset();
_manager.addConfigChangeListener(listener, ConfigScopeProperty.CLUSTER);
boolean result = TestHelper.verify(()-> {
- return listener._configChanged == true;
+ return listener._configChanged;
}, TestHelper.WAIT_DURATION);
Assert.assertTrue(result,"Should get initial clusterConfig callback
invoked");
Assert.assertEquals(listener._configSize, 1, "Cluster Config size should
be 1");
listener.reset();
_manager.addConfigChangeListener(listener, ConfigScopeProperty.RESOURCE);
+ result = TestHelper.verify(()-> {
+ return listener._configChanged;
+ }, TestHelper.WAIT_DURATION);
Assert.assertTrue(listener._configChanged,
Review comment:
nit, this one shall assert the result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
