kaisun2000 commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r501409817
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/changedetector/TestResourceChangeDetector.java
##########
@@ -422,16 +425,23 @@ public void testIgnoreNonTopologyChanges() {
}
}
- @Test(dependsOnMethods = "testIgnoreNonTopologyChanges")
+ static final int WAIT_TIME = 30 * 60 * 1000;
Review comment:
No need to wait so long as the root cause is known.
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/changedetector/TestResourceChangeDetector.java
##########
@@ -422,16 +425,23 @@ public void testIgnoreNonTopologyChanges() {
}
}
- @Test(dependsOnMethods = "testIgnoreNonTopologyChanges")
+ static final int WAIT_TIME = 30 * 60 * 1000;
+ @Test(dependsOnMethods = "testIgnoreNonTopologyChanges", timeOut = 30 * 60 *
1000)
Review comment:
remove timeout.
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThrottle.java
##########
@@ -278,8 +278,8 @@ public void testThrottleOnlyClusterLevelAnyType() {
ClusterLiveNodesVerifier liveNodesVerifier =
new ClusterLiveNodesVerifier(_gZkClient, CLUSTER_NAME,
Lists.transform(Arrays.asList(_participants),
MockParticipantManager::getInstanceName));
- Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(1000));
- Assert.assertTrue(_clusterVerifier.verifyByPolling());
+ Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(5000));
+ // Assert.assertTrue(_clusterVerifier.verifyByPolling());
Review comment:
remove.
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/TaskGarbageCollectionStage.java
##########
@@ -78,6 +78,7 @@ public void process(ClusterEvent event) throws Exception {
}
long currentTime = System.currentTimeMillis();
long nextPurgeTime = workflowContext.getLastJobPurgeTime() +
purgeInterval;
+
Review comment:
remove.
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java
##########
@@ -415,7 +415,7 @@ public void testDanglingCallbackHanlderFix() throws
Exception {
System.out.println("END " + clusterName + " at " + new
Date(System.currentTimeMillis()));
}
- @Test
+ @Test(timeOut = 1800 * 1000)
Review comment:
remove.
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/TaskGarbageCollectionStage.java
##########
@@ -78,6 +78,7 @@ public void process(ClusterEvent event) throws Exception {
}
long currentTime = System.currentTimeMillis();
long nextPurgeTime = workflowContext.getLastJobPurgeTime() +
purgeInterval;
+
Review comment:
fixed.
##########
File path: helix-core/src/test/java/org/apache/helix/TestHelper.java
##########
@@ -37,6 +37,8 @@
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
+import java.util.function.Predicate;
+import java.util.stream.Collectors;
Review comment:
not needed, remove
##########
File path: helix-core/src/test/java/org/apache/helix/TestZKCallback.java
##########
@@ -166,6 +166,7 @@ public void testInvocation() throws Exception {
ExternalView extView = new ExternalView("db-12345");
accessor.setProperty(keyBuilder.externalView("db-12345"), extView);
+
Review comment:
removed.
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/changedetector/TestResourceChangeDetector.java
##########
@@ -422,16 +425,23 @@ public void testIgnoreNonTopologyChanges() {
}
}
- @Test(dependsOnMethods = "testIgnoreNonTopologyChanges")
+ static final int WAIT_TIME = 30 * 60 * 1000;
Review comment:
fixed.
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/changedetector/TestResourceChangeDetector.java
##########
@@ -422,16 +425,23 @@ public void testIgnoreNonTopologyChanges() {
}
}
- @Test(dependsOnMethods = "testIgnoreNonTopologyChanges")
+ static final int WAIT_TIME = 30 * 60 * 1000;
+ @Test(dependsOnMethods = "testIgnoreNonTopologyChanges", timeOut = 30 * 60 *
1000)
Review comment:
fixed.
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java
##########
@@ -157,7 +157,7 @@ public void testDuplicateMsg() throws Exception {
Thread.sleep(2 * MessageGenerationPhase.DEFAULT_OBSELETE_MSG_PURGE_DELAY);
runPipeline(event, dataRefresh, false);
-
+
Review comment:
remove.
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThrottle.java
##########
@@ -278,8 +278,8 @@ public void testThrottleOnlyClusterLevelAnyType() {
ClusterLiveNodesVerifier liveNodesVerifier =
new ClusterLiveNodesVerifier(_gZkClient, CLUSTER_NAME,
Lists.transform(Arrays.asList(_participants),
MockParticipantManager::getInstanceName));
- Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(1000));
- Assert.assertTrue(_clusterVerifier.verifyByPolling());
+ Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(5000));
+ // Assert.assertTrue(_clusterVerifier.verifyByPolling());
Review comment:
remove.
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestRebalancerPersistAssignments.java
##########
@@ -29,6 +29,7 @@
import org.apache.helix.TestHelper;
import
org.apache.helix.controller.rebalancer.strategy.CrushEdRebalanceStrategy;
import org.apache.helix.controller.rebalancer.strategy.RebalanceStrategy;
+import org.apache.helix.TestHelper;
Review comment:
remove
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java
##########
@@ -415,7 +415,7 @@ public void testDanglingCallbackHanlderFix() throws
Exception {
System.out.println("END " + clusterName + " at " + new
Date(System.currentTimeMillis()));
}
- @Test
+ @Test(timeOut = 1800 * 1000)
Review comment:
fixed
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/DelayedAutoRebalancer/TestDelayedAutoRebalance.java
##########
@@ -105,16 +105,20 @@ public void beforeClass() throws Exception {
*/
@Test
public void testDelayedPartitionMovement() throws Exception {
+ System.out.println("START
TestDelayedAutoRebalance::testDelayedPartitionMovement");
Map<String, ExternalView> externalViewsBefore = createTestDBs(1000000);
validateDelayedMovements(externalViewsBefore);
+ System.out.println("START
TestDelayedAutoRebalance::testDelayedPartitionMovement");
Review comment:
Changed to END
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
