lei-xia commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r501988944
##########
File path: helix-core/src/test/java/org/apache/helix/TestListenerCallback.java
##########
@@ -119,6 +119,8 @@ public void beforeClass() throws Exception {
@AfterClass
public void afterClass() throws Exception {
+ String testClassName = this.getShortClassName();
Review comment:
Let us make this name consistent with line 102-103, i.e, either fix that
or change this line to make them consistent.
##########
File path:
helix-core/src/test/java/org/apache/helix/TestListenerCallbackBatchMode.java
##########
@@ -119,6 +119,9 @@ public void beforeClass()
@AfterClass
public void afterClass()
throws Exception {
+ String testClassName = this.getShortClassName();
Review comment:
Do we need one in BeforeClass? If we need this being print out before
and after class methods, should we put this into ZkTestBase (like what we do in
for beforeTest and afterTest in ZkTestBase)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
