kaisun2000 commented on pull request #1455: URL: https://github.com/apache/helix/pull/1455#issuecomment-705926326
> I have concerns about this PR. > > 1. The way we disable purge is by setting the config everywhere. As we discussed, it is a temporary resolution. When we need to remove them, it would be messy. > 2. This PR mixes other changes with the purge change. Meaning we cannot revert it to remove the temporary "fix". > 3. I think we agreed on wait until Neal evaluate the ETA of a more graceful temp solution, do we have the conclusion yet? > 4. I think we can refactor a little bit by leveraging parent class. The current PR introduces lots of duplicate logic. 3/ Last time we discussed, the conclusion is that let Neal work on read one more time before purging as a temp solution. I will help to validate by reproducing the phantom read problem in the debugger. Let us sync about this tomorrow then. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
