NealSun96 commented on a change in pull request #1455:
URL: https://github.com/apache/helix/pull/1455#discussion_r502701244
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java
##########
@@ -413,25 +447,38 @@ public void stopAndDeleteQueue() throws Exception {
// Create a queue
System.out.println("START " + queueName + " at " + new
Date(System.currentTimeMillis()));
WorkflowConfig wfCfg =
- new WorkflowConfig.Builder(queueName).setExpiry(2,
TimeUnit.MINUTES).build();
+ new WorkflowConfig.Builder(queueName).setExpiry(2, TimeUnit.MINUTES)
+ .setJobPurgeInterval(-1)
+ .build();
JobQueue qCfg = new
JobQueue.Builder(queueName).fromMap(wfCfg.getResourceConfigMap()).build();
_driver.createQueue(qCfg);
// Enqueue 2 jobs
+ List<String> jobNames = new ArrayList<>();
+ List<JobConfig.Builder> jobBuilders = new ArrayList<>();
+
Set<String> master = Sets.newHashSet("MASTER");
JobConfig.Builder job1 = new
JobConfig.Builder().setCommand(MockTask.TASK_COMMAND)
+ .setJobCommandConfigMap(Collections.singletonMap(MockTask.JOB_DELAY,
"2000"))
Review comment:
This is certainly harmless because we poll for completed. What is the
reason why we need the delay, though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
