kaisun2000 commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r508914742
##########
File path:
helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java
##########
@@ -291,7 +292,14 @@ public void testClusterStatusMonitorLifecycle() throws
Exception {
Query.not(Query.match(Query.attr("SensorName"),
Query.value("MessageQueueStatus.*"))),
exp1);
- Assert.assertTrue(TestHelper.verify(() ->
ManagementFactory.getPlatformMBeanServer()
- .queryMBeans(new ObjectName("ClusterStatus:*"), exp2).isEmpty(),
3000));
+ // Note, the _asyncTasksThreadPool shutting down logic in
GenericHelixController is best effort
+ // there is not guarantee that all threads in the pool is gone. MOstly
they will, but not always.
+ // see https://github.com/apache/helix/issues/1280
+ boolean result = TestHelper.verify(() ->
ManagementFactory.getPlatformMBeanServer()
+ .queryMBeans(new ObjectName("ClusterStatus:*"), exp2).isEmpty(),
TestHelper.WAIT_DURATION);
+
+ if (!result) {
+ System.out.println("controllers shutting down failed to tear down all
_asyncTasksThreadPools");
+ }
Review comment:
Assert the result, but in the error message we alert user this can
happen due to ....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
