kaisun2000 commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r508972255
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/CrushRebalancers/TestCrushAutoRebalance.java
##########
@@ -298,7 +298,7 @@ private void validateZoneAndTagIsolation(IdealState is,
ExternalView ev, int exp
Assert.assertEquals(assignedZones.size(), expectedReplica);
}
}
-
+/* These blank test would cause @AfterClass not get invoked.
Review comment:
>Start zookeeper at localhost:2183 in thread main
START TestCrushAutoRebalance at Tue Oct 20 20:43:11 PDT 2020
START TestCrushAutoRebalance testZoneIsolationWithInstanceTag at Tue Oct 20
20:43:13 PDT 2020
END TestCrushAutoRebalance testZoneIsolationWithInstanceTag at Tue Oct 20
20:43:15 PDT 2020, took: 1811ms.
START TestCrushAutoRebalance testZoneIsolationWithInstanceTag at Tue Oct 20
20:43:15 PDT 2020
END TestCrushAutoRebalance testZoneIsolationWithInstanceTag at Tue Oct 20
20:43:16 PDT 2020, took: 1773ms.
START TestCrushAutoRebalance testZoneIsolationWithInstanceTag at Tue Oct 20
20:43:16 PDT 2020
END TestCrushAutoRebalance testZoneIsolationWithInstanceTag at Tue Oct 20
20:43:18 PDT 2020, took: 1718ms.
START TestCrushAutoRebalance testZoneIsolation at Tue Oct 20 20:43:18 PDT
2020
END TestCrushAutoRebalance testZoneIsolation at Tue Oct 20 20:43:20 PDT
2020, took: 1663ms.
START TestCrushAutoRebalance testZoneIsolation at Tue Oct 20 20:43:20 PDT
2020
END TestCrushAutoRebalance testZoneIsolation at Tue Oct 20 20:43:21 PDT
2020, took: 1731ms.
START TestCrushAutoRebalance testZoneIsolation at Tue Oct 20 20:43:21 PDT
2020
END TestCrushAutoRebalance testZoneIsolation at Tue Oct 20 20:43:23 PDT
2020, took: 1672ms.
START TestCrushAutoRebalance testLackEnoughLiveRacks at Tue Oct 20 20:43:23
PDT 2020
END TestCrushAutoRebalance testLackEnoughLiveRacks at Tue Oct 20 20:43:25
PDT 2020, took: 1817ms.
START TestCrushAutoRebalance testLackEnoughRacks at Tue Oct 20 20:43:25 PDT
2020
END TestCrushAutoRebalance testLackEnoughRacks at Tue Oct 20 20:43:27 PDT
2020, took: 1819ms.
END TestCrushAutoRebalance at Tue Oct 20 20:43:27 PDT 2020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
