narendly commented on a change in pull request #1494:
URL: https://github.com/apache/helix/pull/1494#discussion_r514896634
##########
File path: helix-core/src/main/java/org/apache/helix/HelixAdmin.java
##########
@@ -228,6 +228,13 @@ void addResource(String clusterName, String resourceName,
int numPartitions, Str
*/
void dropInstance(String clusterName, InstanceConfig instanceConfig);
+ /**
+ * Purge offline instances from a cluster
+ * @param clusterName
+ * @param timeout
+ */
+ void purgeOfflineInstances(String clusterName, Long timeout);
Review comment:
i think the javadoc here could use more work. we should try to add more
context on why and when the interface should be used.
also i'm not sure `timeout` is the right term for this. perhaps rename it to
something like `offlineDuration`? also if you could please add a description as
to how this `offlineDuration` is measured/calculated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
