narendly commented on a change in pull request #1494:
URL: https://github.com/apache/helix/pull/1494#discussion_r514897345
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
##########
@@ -2061,4 +2069,43 @@ public ZKHelixAdmin build() {
_zkAddress), false);
}
}
+
+ private Map<String, InstanceConfig> findTimeoutOfflineInstances(String
clusterName,
+ Long timeout) {
+ Map<String, InstanceConfig> instanceConfigMap = new HashMap<>();
+ // in case there is no customized timeout value, use the one defined in
cluster config
+ if (timeout == null) {
+ timeout =
_configAccessor.getClusterConfig(clusterName).getOfflineNodeTimeOutForPurge();
+ }
Review comment:
instead of doing the `null` check, maybe you could define a `NOT_SET`
constant of some sort...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
