zhangmeng916 commented on a change in pull request #1504:
URL: https://github.com/apache/helix/pull/1504#discussion_r518325010
##########
File path: helix-core/src/main/java/org/apache/helix/NotificationContext.java
##########
@@ -227,4 +228,12 @@ public void setPathChanged(String pathChanged) {
public void setChangeType(HelixConstants.ChangeType changeType) {
this._changeType = changeType;
}
+
+ public boolean getIsChildChange() {
+ return _isChildChange;
+ }
+
+ public void setIsChildChange(boolean cc) {
Review comment:
You may want to change cc to a more meaningful meaning, like childChange.
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java
##########
@@ -467,23 +464,31 @@ public void testCurrentStatePathLeakingByAsycRemoval()
throws Exception {
cs.setSessionId(jobSessionId);
cs.setStateModelDefRef(db0.getStateModelDefRef());
+ Map<String, List<String>> rpWatchPaths =
ZkTestHelper.getZkWatch(rpManager.getZkClient());
+
Assert.assertFalse(rpWatchPaths.get("dataWatches").contains(jobKey.getPath()));
+
LOG.info("add job");
- boolean rtJob = false;
for (int i = 0; i < mJobUpdateCnt; i++) {
- rtJob = jobAccesor.setProperty(jobKey, cs);
+ jobAccesor.setProperty(jobKey, cs);
}
+ // verify new watcher is installed on the new node
+ Thread.sleep(5000);
Review comment:
I think we try to get rid of this kind of thread sleep, and use
verifier. But as this is legacy test, I think it's fine. You can let
@kaisun2000 know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
