xyuanlu commented on a change in pull request #1504:
URL: https://github.com/apache/helix/pull/1504#discussion_r519069321
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java
##########
@@ -467,23 +464,31 @@ public void testCurrentStatePathLeakingByAsycRemoval()
throws Exception {
cs.setSessionId(jobSessionId);
cs.setStateModelDefRef(db0.getStateModelDefRef());
+ Map<String, List<String>> rpWatchPaths =
ZkTestHelper.getZkWatch(rpManager.getZkClient());
+
Assert.assertFalse(rpWatchPaths.get("dataWatches").contains(jobKey.getPath()));
+
LOG.info("add job");
- boolean rtJob = false;
for (int i = 0; i < mJobUpdateCnt; i++) {
- rtJob = jobAccesor.setProperty(jobKey, cs);
+ jobAccesor.setProperty(jobKey, cs);
}
+ // verify new watcher is installed on the new node
+ Thread.sleep(5000);
Review comment:
Thanks for offline discuss. Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
