jiajunwang opened a new pull request #1514: URL: https://github.com/apache/helix/pull/1514
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: Resolves #1513 ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: The retry count will be counted when message handler creation fails or state transition times out. In addition, this PR also improves several ambiguous behaviors that may block a normal retry. 1. The cache of known messages list in HelixTaskExecutor may not be updated correctly if a message is going to be retried. 2. The retry count is not strictly followed in some conditions. 3. The to-be-retried message won't be automatically read when there are no other new message changes. Finally, improve the tests to cover the new changes. ### Tests - [X] The following tests are written for this issue: TestStateTransitionAppFailureHandling - [X] The following is the result of the "mvn test" command on the appropriate module: [ERROR] Failures: [ERROR] TestTaskRebalancerFailover.test ยป ThreadTimeout Method org.testng.internal.Tes... [INFO] [ERROR] Tests run: 1247, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:36 h [INFO] Finished at: 2020-11-06T00:46:51-08:00 [INFO] ------------------------------------------------------------------------ Rerun the test and it will pass. But it is not stable due to issue #1512 ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
