jiajunwang commented on a change in pull request #1514:
URL: https://github.com/apache/helix/pull/1514#discussion_r520824143
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -1288,6 +1308,19 @@ private void removeMessageFromZK(HelixDataAccessor
accessor, Message message,
}
}
+ private void sendNopMessage(HelixDataAccessor accessor, String instanceName)
{
+ try {
+ Message nopMsg = new Message(MessageType.NO_OP,
UUID.randomUUID().toString());
+ nopMsg.setSrcName(instanceName);
+ nopMsg.setTgtName(instanceName);
+ accessor
+ .setProperty(accessor.keyBuilder().message(nopMsg.getTgtName(),
nopMsg.getId()), nopMsg);
+ LOG.info("Send NO_OP message to " + nopMsg.getTgtName() + ", msgId: " +
nopMsg.getId());
+ } catch (Exception e) {
+ LOG.error(e.toString());
Review comment:
I agree, it was copy-pasted. Let me make it complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
