jiajunwang opened a new pull request #1515: URL: https://github.com/apache/helix/pull/1515
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: Workaround for #1512 ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: There is a race condition between TaskExecutor thread pool shutting down and Message handler stops listening. In this gap, the message will still be processed but the schedule will fail. If we mark partition into an ERROR state, then the controller side logic might be confused. This PR adds an additional check to avoid the unnecessary ERROR state. But please note this is a workaround instead complete fix. ### Tests - [X] The following tests are written for this issue: NA, it has been tested by TestTaskRebalancerFailover. Without this fix, the test case will fail. - [ ] The following is the result of the "mvn test" command on the appropriate module: Running... ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
