kaisun2000 commented on a change in pull request #1523:
URL: https://github.com/apache/helix/pull/1523#discussion_r520897642
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/TaskDataCache.java
##########
@@ -267,6 +277,10 @@ public void updateWorkflowContext(String resourceName,
WorkflowContext workflowC
* Update context of the Workflow or Job
*/
private void updateContext(String resourceName, ZNRecord record) {
+ if (record != null && _initialContextMapHashcode.containsKey(resourceName)
+ &&
_initialContextMapHashcode.get(resourceName).equals((record.toString().hashCode())))
{
+ return;
+ }
Review comment:
The problem I see here is that hash code equals does not mean the
content is equal, right?
hashcode1 ! = hashcode2 ==> content1 != content2: this is fine
hashcode1 == hashcode2 ==> content1 == content2: this is not true. Unless
you use security hash, the probability is very high that this is true.
Or is it that I did not fully understand the intention here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
