kaisun2000 commented on a change in pull request #1523:
URL: https://github.com/apache/helix/pull/1523#discussion_r520929697
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/TaskDataCache.java
##########
@@ -267,6 +277,10 @@ public void updateWorkflowContext(String resourceName,
WorkflowContext workflowC
* Update context of the Workflow or Job
*/
private void updateContext(String resourceName, ZNRecord record) {
+ if (record != null && _initialContextMapHashcode.containsKey(resourceName)
+ &&
_initialContextMapHashcode.get(resourceName).equals((record.toString().hashCode())))
{
+ return;
+ }
Review comment:
Can we do something like if hash equals, let to do a further check of
content equality before skipping it? otherwise, this code has the potential of
losing update, which would be hard to debug in the field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
